Email: Password: Remember Me | Create Account (Free)

Back to Subject List

Old thread has been locked -- no new posts accepted in this thread
???
10/23/09 15:55
Read: times


 		 #170012 - Careful Commenting Catches Cruddy Coding!
Responding to: ???'s previous message
Per Westermark said:
Yes, it is sequences like the following that make us a bit unhappy:
Save This Code
        RETI

SKIP:
        MOV     SBUF,DPH
        RETI
FINISH: RETI

SKIP: isn't used.
FINISH: isn't used.
There are a lot of RETI randomly placed.

If the OP would take the care to go through his code and comment it - as has repeatedly been suggested - he should spot this kind of stuff himself in the process!
See: http://www.8052.com/forum/read/169939

If he would also go through it step-by-step in a "manual" simulation, that would also reveal these things!
See: http://www.8052.com/forum/read/169932

List of 26 messages in thread
TopicAuthorDate
Is this Code Correct for 16 Bit Serial Transmission            01/01/70 00:00      
   No.            01/01/70 00:00      
      Sir            01/01/70 00:00      
         Insert program code            01/01/70 00:00      
            How to post legible source code            01/01/70 00:00      
            Who would bother to read uncommented code?            01/01/70 00:00      
               Worse than that            01/01/70 00:00      
         So you will understand            01/01/70 00:00      
   what code?            01/01/70 00:00      
      Program with comments            01/01/70 00:00      
         The first after it            01/01/70 00:00      
            Second after it.......            01/01/70 00:00      
               Simulators            01/01/70 00:00      
               Remove all the silly code lines!            01/01/70 00:00      
                  Comments first, then discussing intention/reality            01/01/70 00:00      
                     Careful Commenting Catches Cruddy Coding!            01/01/70 00:00      
            So where did all the comments go?!            01/01/70 00:00      
               To achieve 16 bit communication            01/01/70 00:00      
                  Exactly what was your "target"?            01/01/70 00:00      
                  How?            01/01/70 00:00      
            Return from interrupt            01/01/70 00:00      
               Of course not            01/01/70 00:00      
                  But how it could be different            01/01/70 00:00      
                     Any more information required            01/01/70 00:00      
                        As previously stated            01/01/70 00:00      
                           and summarised...            01/01/70 00:00      

Back to Subject List