??? 07/17/09 09:42 Read: times |
#167471 - dangerous loops Responding to: ???'s previous message |
Why not format the code as code? Would it have been to easy to read?
Your only use of comments seems to be to deactivate code. Have you looked through your algorithm? You seem to assume that if you get past your first loop, you will always get an assign to "row" and "col". Is that really true? What would happen if you press a key too short time so your "col" scan doesn't see anything? You have a 4*4 keypad, but you are using all 8 bits of two ports. Shouldn't you mask away the bits that are not used? |
Topic | Author | Date |
Keypad interface problem: My code not working.. | 01/01/70 00:00 | |
Check in a simulator | 01/01/70 00:00 | |
RE: | 01/01/70 00:00 | |
Care for details | 01/01/70 00:00 | |
Formatted code | 01/01/70 00:00 | |
RE: i dint check the bounce | 01/01/70 00:00 | |
Bounce vital to think about | 01/01/70 00:00 | |
Do document | 01/01/70 00:00 | |
re: documentation prob | 01/01/70 00:00 | |
Fixing prob: | 01/01/70 00:00 | |
Did you search? | 01/01/70 00:00 | |
RE: the search tool here is not the most powerful | 01/01/70 00:00 | |
Karas's Keypad Scanner Code In C - detabbed | 01/01/70 00:00 | |
Properly documented code | 01/01/70 00:00 | |
Reasons and assumptions | 01/01/70 00:00 | |
Per, you implied, but did not say | 01/01/70 00:00 | |
dangerous loops | 01/01/70 00:00 | |
code??? | 01/01/70 00:00 | |
RE: now am modified my code | 01/01/70 00:00 | |
How to post legible source code | 01/01/70 00:00 | |
unfortunately, that does not add comments | 01/01/70 00:00 | |
re: thanks now i got how to insert code | 01/01/70 00:00 | |
Scanning Keypad | 01/01/70 00:00 | |
How to scan Keypad![]() | 01/01/70 00:00 |