1) Get a copy of "Code Complete" by Steve McConnell, and "Writing Solid Code" by Steve Maguire. Apply their concepts.

2) Define "hang." It will mean different things to different people.

3) Fill all unused code areas with a "safe" value, such as "02 00 00", which is a jump to the reset address. It is "safe" because if the code starts executing at a location with 00, it gets treated as a NOP command. Or if your code is sequential (no gaps between code blocks, just fill the unused areas with 00.

4) Make sure you deal with unexpected input values. Each IF construct should have an ELSE, each SWITCH/CASE should have a DEFAULT.

5) USE COMMENTS! Tell what you are trying to achieve, NOT what the code is doing!!

    MOV    R0,#Buffer ; load R0
    MOV    A,@R0      ; load acc from R0
    ADD    A,#30      ; add 30
    MOV    @R0,A      ; Store result

 

is useless!

; convert numbers (0..9) in buffer into ASCII values
    MOV    R0,#Buffer
    MOV    A,@R0
    ADD    A,#'0'
    MOV    @R0,A

 

tells WHAT is being done, along with the assumption that the buffer has only digits in it.

6) Get a copy of "Code Complete" by Steve McConnell, and "Writing Solid Code" by Steve Maguire. Apply their concepts.

--Rich