Hi

We are using 8052 in our project. We are using 128K EPROM, and using Code Banking of Keil with 2 code banks. We are cross-checking our code using PC-Lint ver 9.0f.

We increased the warning level by making changes to the co-kc51.lnt file. We added -w4 and ran PC-Lint. Then, PC-Lint generated the following Elective Notes:

#include<Reg52.h>
bit trans_ready;
void sendDataToSerialPort(unsigned char i)
{
	trans_ready = 0;	/* Clearing the data transmitted flag */
	SBUF = i;		/* Sending data to Serial Buffer. This is Line 38 */
	while(!trans_ready)	/* Waiting till this flag is set in Serial Routine */
}

Note 952: Parameter 'i' (line 38) could be declared const.

There are nearly 150 functions for which PC-Lint suggested this. All function parameters are non-pointers.

There is no change in the compiled data after adding 'const' as shown:

void sendDataToSerialPort(const unsigned char i)
{
	trans_ready = 0;	/* Clearing the data transmitted flag */
	SBUF = i;		/* Sending data to Serial Buffer. This is Line 38 */
	while(!trans_ready)	/* Waiting till this flag is set in Serial Routine */
}
 

Q1. What will be the impact on the performance by declaring this function parameter as 'const'?

The extern declaration is:

extern void sendDataToSerialPort(unsigned char);

Q2. Is it required to use const in this function prototype declaration also?

Please suggest.

thanks in advance.